Skip to content

Add: Dockerfiles for Packages #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xsscx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add: Dockerfiles for Packages #597

xsscx wants to merge 2 commits into from

Conversation

@xsscx
Copy link
Member

@xsscx xsscx commented Feb 11, 2026

Pull Request Checklist

#596

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@xsscx xsscx requested a review from ChrisCoxArt February 11, 2026 18:57
@xsscx xsscx self-assigned this Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 18:57
@xsscx xsscx added PR Pull Request Merge Ready Maintainer indicates Merge Ready Docker Docker Information CI labels Feb 11, 2026
@xsscx xsscx linked an issue Feb 11, 2026 that may be closed by this pull request
Add: Dockerfile Configs for Packages #596
Open
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Docker containerization support for the iccDEV project, introducing two Dockerfiles to build and distribute iccDEV tools and libraries as container images. This aligns with issue #596 to create packages for the GitHub Container Registry.

Changes:

  • Added multi-stage Dockerfile for Ubuntu-based builds with ASAN/UBSAN instrumentation
  • Added Dockerfile.nixos for NixOS-based builds with wxWidgets support
  • Configured containers with pre-built iccDEV tools and libraries accessible via PATH

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.

File Description
Dockerfile Multi-stage Ubuntu 26.04 build with Clang-18, ASAN, UBSAN, and automated test execution
Dockerfile.nixos NixOS-based single-stage build using nix-shell with full dependency management

@xsscx xsscx added Test Status Maintainer indicates TEST Status and removed Merge Ready Maintainer indicates Merge Ready labels Feb 11, 2026
@xsscx xsscx mentioned this pull request Feb 11, 2026
Open
@xsscx xsscx requested a review from dwtza as a code owner February 11, 2026 23:52
@xsscx xsscx requested a review from Copilot February 11, 2026 23:59
Copilot AI reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

@xsscx xsscx force-pushed the dockerfiles branch 2 times, most recently from d2a66d1 to adb5486 Compare February 12, 2026 00:16
@xsscx xsscx requested a review from Copilot February 12, 2026 00:29
@xsscx
Copy link
Member Author

xsscx commented Feb 12, 2026

Status of Outputs

2026-02-12 00:30:59 UTC

Build & Output to Packages

https://github.com/InternationalColorConsortium/iccDEV/pkgs/container/iccdev-latest

Need to consider Tags etc.

Copilot AI reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@xsscx xsscx requested a review from Copilot February 12, 2026 01:00
@xsscx xsscx added the Copilot Review Reviewed by Copilot label Feb 12, 2026
Copilot AI reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

@xsscx
Copy link
Member Author

xsscx commented Feb 12, 2026

This the result of a Copilot Suggestion:

Invalid workflow file: .github/workflows/ci-docker-latest.yml#L1
(Line: 38, Col: 19): Unrecognized function: 'toLower'. Located at position 1 within expression: toLower(github.repository_owner)

@xsscx
Modify: ci-docker-latest to Release Build Type
0683c82 
Modify: ci-docker-latest to Release Build Type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ChrisCoxArt ChrisCoxArt Awaiting requested review from ChrisCoxArt

@dwtza dwtza Awaiting requested review from dwtza dwtza is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@xsscx xsscx

Labels

CI Copilot Review Reviewed by Copilot Docker Docker Information PR Pull Request Test Status Maintainer indicates TEST Status

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add: Dockerfile Configs for Packages

1 participant

@xsscx